-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Configurator support for new OSD feature Camera Angle Reference #3570
base: master
Are you sure you want to change the base?
Adding Configurator support for new OSD feature Camera Angle Reference #3570
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
IMG_6179.mov |
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
Depends on betaflight/betaflight#13070 |
What's the difference between this new 'artificial horizon' type indicator, and the old one? |
i believe it refers to |
@MedlinDrone, you don't have to change language other than en since Crowin will add to the other languages. |
@ctzsnooze what @nerdCopter is correct, when flying with a single-axis tilt gimbal (like those on medlindrone.com) this shows you an artificial propeller line/cockpit so that you know what camera angle you are at. |
@HThuren Thanks for letting me know, I added the entries into the various messages files in English just to make sure it didn't break anything, is that the correct way to do it or should I not touch the other languages message files? |
Hi @MedlinDrone, no, you just add to the en file, Crowdin do the rest. |
@MedlinDrone you can cover up by doing a "git restore xx" where xx are full path to the language files other than "en" |
34a4264
to
6fe7b76
Compare
@HThuren I updated the pull request, now it only includes the English messages file |
CAR 'Camera Angle Reference' CLI Values. -CAR Channel controlling servo/gimbal -CAR Scale for adjusting vertical scale / sesitivity -CAR Dots for adjusting number of dots on each side -CAR Width for adjusting witdh between dots CAR Sidebar Values. -CAR Sidebar Scale for adjusting vertical scale -CAR Sidebar angle 1/5 -CAR Sidebar angle 2/5 -CAR Sidebar angle 3/5 -CAR Sidebar angle 4/5 -CAR Sidebar angle 5/5 |
This comment has been minimized.
This comment has been minimized.
SidebarClipLowRes.mp4 |
This is an OSD visual reference for current camera angle (open to name changes) intended to be used with a single axis tilt gimbal, like those shown on medlindrone.com For 'Camera Angle Reference' there are five new cli parameters: -osd_car_pos (osd element position) -osd_car_channel (channel controlling the gimbal/car) -osd_car_scale (scale for adjusting vertical scale/sensitivity) -osd_car_width (width for adjusting witdh between dots) -osd_car_dots (number of dots on each side) For 'Camera Angle Reference Sidebar' there are seven new cli parameters: -osd_car_sbar_pos; (osd element position) -osd_car_sbar_scale; (scale for adjusting vertical scale) -osd_car_sbar_low; (angle 1/5) -osd_car_sbar_mid_low; (angle 2/5) -osd_car_sbar_mid; (angle 3/5) -osd_car_sbar_mid_high; (angle 4/5) -osd_car_sbar_high; (angle 5/5) Added UI in OSD tab to changes CLI values, "Camera Angle Reference' section on right side
72c2e99
to
9d8cbea
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
Camera Angle Reference OSD Feature
Requires: betaflight/betaflight#13070
This is my first pull request so be gentle. Will be submitting the Betaflight pull request directly after submitting configurator and will reference this pull request in the other.
This is an OSD visual reference for current camera angle intended to be used with a single axis tilt gimbal, like those shown on medlindrone.com
This is currently configured via CLI, will add a GUI for it in the future.
There are five new cli parameters:
-osd_car_pos (osd element position)
-osd_car_channel (channel controlling the gimbal/apl)
-osd_car_scale (scale for adjusting vertical scale / sensitivity)
-osd_car_width (width for adjusting witdh between dots)
-osd_car_dots (number of dots on each side)
Discussion betaflight/betaflight#12438